style/quality only

No functional changes.

- add `override' everywhere where missing
- almost pass clang's `-Wweak-vtables'
- avoid some float/double conversions
- remove unused private members
- make signedness conversions explicit
- put stuff in right namespaces to aid analysis

1 files changed, 8 insertions, 5 deletions

diff --git a/migration/migration.cpp b/migration/migration.cpp
index 45965bee..59ceee1a 100644
--- a/migration/migration.cpp
+++ b/migration/migration.cpp
@@ -24,9 +24,7 @@ using namespace options::globals;
 
 // individual migrations are run in the UI thread. they can be interactive if necessary.
 
-namespace migrations {
-
-namespace detail {
+namespace migrations::detail {
 
 static std::vector<mptr> migration_list;
 static std::vector<mfun> migration_thunks;
@@ -180,9 +178,14 @@ std::vector<QString> migrator::run()
     return done;
 }
 
-}
+} // ns migrations::detail
+
+namespace migrations {
+
+migration::migration() = default;
+migration::~migration() = default;
 
-} // ns
+} // ns migrations
 
 std::vector<QString> run_migrations()
 {