rewrite bitmask impl

It's slower than the previous version but fixes a bug when stride isn't
a multiple of 8.

It can be improved further by setting `auto& byte` all at once instead
of setting individual bits of multiple bytes in the innermost loop.

------------------------------------------------------------
New version                Time             CPU   Iterations
------------------------------------------------------------
Bitmask_mean            1911 us         1893 us            5
Bitmask_median          1911 us         1885 us            5
Bitmask_stddev          2.00 us         18.7 us            5
Bitmask_cv              0.10 %          0.99 %             5
-------------------------------------------------------------

------------------------------------------------------------
Buggy version              Time             CPU   Iterations
------------------------------------------------------------
Bitmask_mean             841 us          841 us            5
Bitmask_median           839 us          837 us            5
Bitmask_stddev          3.29 us         7.80 us            5
Bitmask_cv              0.39 %          0.93 %             5
------------------------------------------------------------

-----------------------------------------------------------
Naive version              Time             CPU   Iterations
------------------------------------------------------------
Bitmask_mean            4006 us         3997 us           10
Bitmask_median          4006 us         3997 us           10
Bitmask_stddev          2.29 us        0.000 us           10
Bitmask_cv              0.06 %          0.00 %            10
------------------------------------------------------------

1 files changed, 2 insertions, 30 deletions

diff --git a/src/anim-atlas.cpp b/src/anim-atlas.cpp
index 3386de06..355ddeac 100644
--- a/src/anim-atlas.cpp
+++ b/src/anim-atlas.cpp
@@ -1,7 +1,6 @@
 #include "anim-atlas.hpp"
 #include "compat/assert.hpp"
 #include "shaders/shader.hpp"
-#include "tile-defs.hpp"
 #include "compat/exception.hpp"
 #include <Corrade/Containers/BitArrayView.h>
 #include <Corrade/Containers/StridedArrayView.h>
@@ -16,29 +15,6 @@ static constexpr inline auto rot_count = size_t(rotation_COUNT);
 static_assert(std::size(name_array) == rot_count);
 static_assert(rot_count == 8);
 
-namespace {
-
-constexpr uint8_t amin = 32;
-
-CORRADE_ALWAYS_INLINE void make_bitmask_impl(const ImageView2D& tex, BitArray& array)
-{
-    array.resetAll(); // slow
-    const auto pixels = tex.pixels();
-    fm_soft_assert(tex.pixelSize() == 4);
-    fm_soft_assert(pixels.stride()[1] == 4);
-
-    const auto* const src = (const unsigned char*)pixels.data();
-    const auto stride = (size_t)pixels.stride()[0];
-    const auto size   = pixels.size();
-    const auto width  = size[1], height = size[0];
-
-    for (auto j = 0u; j < height; j++)
-        for (auto i = 0u; i < width; i++)
-            array.set((height - j - 1)*width + i, src[(j*stride + i*4)+3] >= amin);
-}
-
-} // namespace
-
 uint8_t anim_atlas::rotation_to_index(StringView name)
 {
     for (uint8_t i = 0; i < rot_count; i++)
@@ -156,18 +132,14 @@ auto anim_atlas::frame_quad(const Vector3& center, rotation r, size_t i) const n
     }};
 }
 
-void anim_atlas::make_bitmask_(const ImageView2D& tex, BitArray& array)
-{
-    return make_bitmask_impl(tex, array);
-}
-
 BitArray anim_atlas::make_bitmask(const ImageView2D& tex)
 {
     if (tex.pixelSize() == 3)
         return {};
 
     const auto size = tex.pixels().size();
-    auto array = BitArray{NoInit, size[0]*size[1]};
+    auto width = (size[0]+7)&~7uz;
+    auto array = BitArray{NoInit, width*size[1]};
     make_bitmask_(tex, array);
     return array;
 }