opentrack: only register handlers on dialog creation

Issue: #1407

1 files changed, 6 insertions, 3 deletions

diff --git a/opentrack/main-window.cpp b/opentrack/main-window.cpp
index 404f4067..6ded7919 100644
--- a/opentrack/main-window.cpp
+++ b/opentrack/main-window.cpp
@@ -676,9 +676,12 @@ static void show_module_settings(std::shared_ptr<Instance> instance,
 
     if (!embed)
     {
-        if (instance)
-            ((*dialog).*register_fun)(&*instance);
-        QObject::connect(&*dialog, &BaseDialog::closing, win, [&] { dialog = nullptr; });
+        if (fresh)
+        {
+            if (instance)
+                ((*dialog).*register_fun)(&*instance);
+            QObject::connect(&*dialog, &BaseDialog::closing, win, [&] { dialog = nullptr; });
+        }
         if (show)
             show_window(*dialog, fresh);
     }