clean up a bit

1 files changed, 24 insertions, 22 deletions

diff --git a/api/plugin-api.cpp b/api/plugin-api.cpp
index 5a485d62..404ed434 100644
--- a/api/plugin-api.cpp
+++ b/api/plugin-api.cpp
@@ -2,7 +2,28 @@
 
 #include <utility>
 
-using namespace plugin_api::detail;
+namespace plugin_api::detail {
+
+BaseDialog::BaseDialog() = default;
+void BaseDialog::closeEvent(QCloseEvent*)
+{
+    if (isVisible())
+    {
+        hide();
+        emit closing();
+    }
+}
+
+void BaseDialog::done(int)
+{
+    if (isVisible())
+    {
+        hide();
+        close();
+    }
+}
+
+} // ns plugin_api::detail
 
 // these exist so that vtable is emitted in a single compilation unit, not all of them.
 
@@ -15,17 +36,6 @@ IExtension::~IExtension() = default;
 void ITrackerDialog::register_tracker(ITracker*) {}
 void ITrackerDialog::unregister_tracker() {}
 
-BaseDialog::BaseDialog() = default;
-
-void BaseDialog::closeEvent(QCloseEvent*)
-{
-    if (isVisible())
-    {
-        hide();
-        emit closing();
-    }
-}
-
 bool ITracker::center() { return false; }
 
 module_status ITracker::status_ok()
@@ -46,15 +56,6 @@ IProtocolDialog::IProtocolDialog() = default;
 ITracker::ITracker() = default;
 ITrackerDialog::ITrackerDialog() = default;
 
-void BaseDialog::done(int)
-{
-    if (isVisible())
-    {
-        hide();
-        close();
-    }
-}
-
 IExtensionDialog::~IExtensionDialog() = default;
 
 bool module_status::is_ok() const
@@ -71,6 +72,7 @@ module_status module_status_mixin::error(const QString& error)
     return module_status(error.isEmpty() ? "Unknown error" : error);
 }
 
-
 Metadata::Metadata() = default;
 Metadata::~Metadata() = default;
+
+