clean up "static" and "constexpr" types

- use `static constexpr inline' to avoid requiring
  explicit declarations in object code
- use `const Foo* const' to maybe put into readonly
  binary segment (at least for ELF DSOs)
- `constexpr' in function scope has storage, avoid
  `static'
- don't use `constexpr' where there's no advantage,
  like arrays

We'd like to avoid overhead of atomic initialization
for each function call. No idea how `static constexpr'
requiring storage in the standard plays with atomic
initialization requirement. Hearsay points that
`constexpr' without `static' in block scope behaves
more to our liking. It's all hazy though.

I'm not 100% sure if `static inline constexpr' has any
storage. Hopefully none, like a #define, and stuff
bigger than registers gets coalesced within the same
module, with small stuff being immediates.

1 files changed, 1 insertions, 1 deletions

diff --git a/api/plugin-support.hpp b/api/plugin-support.hpp
index 36a8c2bf..8fc01b98 100644
--- a/api/plugin-support.hpp
+++ b/api/plugin-support.hpp
@@ -159,7 +159,7 @@ private:
                 in = in.mid(pfx_len);
                 in = in.left(in.size() - rst_len);
 
-                static const char* names[] =
+                static constexpr const char* const names[] =
                 {
                     "opentrack-tracker-",
                     "opentrack-proto-",