style/quality only

No functional changes.

- add `override' everywhere where missing
- almost pass clang's `-Wweak-vtables'
- avoid some float/double conversions
- remove unused private members
- make signedness conversions explicit
- put stuff in right namespaces to aid analysis

1 files changed, 2 insertions, 8 deletions

diff --git a/migration/migration.hpp b/migration/migration.hpp
index 42c8bead..4eaa959f 100644
--- a/migration/migration.hpp
+++ b/migration/migration.hpp
@@ -71,25 +71,19 @@ namespace detail {
 #define OPENTRACK_MIGRATION(type) \
     MIGRATE_EXPANDED1(type, MIGRATE_EXPAND1(__COUNTER__))
 
-#ifdef Q_CREATOR_RUN
-#   pragma clang diagnostic ignored "-Wweak-vtables"
-#endif
-
 struct migration
 {
-    migration() = default;
+    migration();
     migration(const migration&) = delete;
     migration& operator=(const migration&) = delete;
 
-    inline virtual ~migration();
+    virtual ~migration();
     virtual QString unique_date() const = 0;
     virtual QString name() const = 0;
     virtual bool should_run() const = 0;
     virtual void run() = 0;
 };
 
-inline migration::~migration() {}
-
 } // ns migrations
 
 OTR_MIGRATION_EXPORT std::vector<QString> run_migrations();