options/value-traits: fix bool storage

Using int as `stored_type' for bool made Qt signals not
work. Evident when ticking the "asymmetric mapping"
checkboxes in the mapping window.

Remove some std::decay_t usage, there's no need for
either decay or remove_cvref.

In `value<t>::get()', `bundle::get_variant' of an
undefined key will fall back to `return def' so remove
the duplicate logic.

1 files changed, 2 insertions, 2 deletions

diff --git a/options/base-value.hpp b/options/base-value.hpp
index 6a4709ee..14eaeb10 100644
--- a/options/base-value.hpp
+++ b/options/base-value.hpp
@@ -43,8 +43,6 @@ public:
         return static_cast<signal_sig<t>>(&value_::valueChanged);
     }
 
-    void notify() const;
-
 signals:
     OTR_OPTIONS_SIGNAL(double);
     OTR_OPTIONS_SIGNAL(float);
@@ -96,6 +94,8 @@ public slots:
     virtual void bundle_value_changed() const = 0;
     virtual void set_to_default() = 0;
 
+    void notify() const;
+
     friend void ::options::detail::set_value_to_default(value_* val);
 };