clean up "static" and "constexpr" types

- use `static constexpr inline' to avoid requiring
  explicit declarations in object code
- use `const Foo* const' to maybe put into readonly
  binary segment (at least for ELF DSOs)
- `constexpr' in function scope has storage, avoid
  `static'
- don't use `constexpr' where there's no advantage,
  like arrays

We'd like to avoid overhead of atomic initialization
for each function call. No idea how `static constexpr'
requiring storage in the standard plays with atomic
initialization requirement. Hearsay points that
`constexpr' without `static' in block scope behaves
more to our liking. It's all hazy though.

I'm not 100% sure if `static inline constexpr' has any
storage. Hopefully none, like a #define, and stuff
bigger than registers gets coalesced within the same
module, with small stuff being immediates.

1 files changed, 0 insertions, 2 deletions

diff --git a/spline/spline.cpp b/spline/spline.cpp
index 823fd64f..fc77bf8b 100644
--- a/spline/spline.cpp
+++ b/spline/spline.cpp
@@ -27,8 +27,6 @@
 
 using namespace spline_detail;
 
-constexpr std::size_t spline::value_count;
-
 spline::spline(const QString& name, const QString& axis_name, Axis axis) :
     axis(axis)
 {