1 files changed, 35 insertions, 35 deletions
diff --git a/api/plugin-api.cpp b/api/plugin-api.cpp
index 5a485d62..b2329f4b 100644
--- a/api/plugin-api.cpp
+++ b/api/plugin-api.cpp
@@ -2,21 +2,9 @@
 
 #include <utility>
 
-using namespace plugin_api::detail;
-
-// these exist so that vtable is emitted in a single compilation unit, not all of them.
-
-Metadata_::~Metadata_() = default;
-IFilter::~IFilter() = default;
-IProtocol::~IProtocol() = default;
-ITracker::~ITracker() = default;
-IExtension::~IExtension() = default;
-
-void ITrackerDialog::register_tracker(ITracker*) {}
-void ITrackerDialog::unregister_tracker() {}
+namespace plugin_api::detail {
 
 BaseDialog::BaseDialog() = default;
-
 void BaseDialog::closeEvent(QCloseEvent*)
 {
     if (isVisible())
@@ -26,35 +14,40 @@ void BaseDialog::closeEvent(QCloseEvent*)
     }
 }
 
-bool ITracker::center() { return false; }
-
-module_status ITracker::status_ok()
+void BaseDialog::done(int)
 {
-    return module_status();
+    if (isVisible())
+    {
+        hide();
+        close();
+    }
 }
 
-module_status ITracker::error(const QString& error)
-{
-    return module_status(error);
-}
+} // ns plugin_api::detail
+
+// these exist so that vtable is emitted in a single compilation unit, not all of them.
 
 Metadata_::Metadata_() = default;
+Metadata_::~Metadata_() = default;
+Metadata::Metadata() = default;
+Metadata::~Metadata() = default;
+
 IFilter::IFilter() = default;
+IFilter::~IFilter() = default;
 IFilterDialog::IFilterDialog() = default;
+IFilterDialog::~IFilterDialog() = default;
 IProtocol::IProtocol() = default;
+IProtocol::~IProtocol() = default;
 IProtocolDialog::IProtocolDialog() = default;
+IProtocolDialog::~IProtocolDialog() = default;
 ITracker::ITracker() = default;
+ITracker::~ITracker() = default;
+bool ITracker::center() { return false; }
 ITrackerDialog::ITrackerDialog() = default;
-
-void BaseDialog::done(int)
-{
-    if (isVisible())
-    {
-        hide();
-        close();
-    }
-}
-
+ITrackerDialog::~ITrackerDialog() = default;
+void ITrackerDialog::register_tracker(ITracker*) {}
+void ITrackerDialog::unregister_tracker() {}
+IExtension::~IExtension() = default;
 IExtensionDialog::~IExtensionDialog() = default;
 
 bool module_status::is_ok() const
@@ -62,8 +55,9 @@ bool module_status::is_ok() const
     return error.isNull();
 }
 
-module_status::module_status(QString error) : error(std::move(error)) {}
-
+module_status_mixin::~module_status_mixin() = default;
+module_status::module_status(const QString& error) : error(error) {}
+module_status::module_status() = default;
 module_status module_status_mixin::status_ok() { return {}; }
 
 module_status module_status_mixin::error(const QString& error)
@@ -71,6 +65,12 @@ module_status module_status_mixin::error(const QString& error)
     return module_status(error.isEmpty() ? "Unknown error" : error);
 }
 
+module_status ITracker::status_ok()
+{
+    return module_status();
+}
 
-Metadata::Metadata() = default;
-Metadata::~Metadata() = default;
+module_status ITracker::error(const QString& error)
+{
+    return module_status(error);
+}