From 162b66f62312280d06b454496804a0956a06fa35 Mon Sep 17 00:00:00 2001 From: Stanislaw Halik Date: Wed, 10 Jan 2018 03:02:31 +0100 Subject: options/value: don't do tree lookup twice --- options/value.hpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/options/value.hpp b/options/value.hpp index 37a2f317..1da1dd9c 100644 --- a/options/value.hpp +++ b/options/value.hpp @@ -48,10 +48,12 @@ class value final : public base_value if (self_name.isEmpty()) return def; - if (!b->contains(self_name) || b->get(self_name).type() == QVariant::Invalid) + QVariant variant = b->get(self_name); + + if (!b->contains(self_name) || variant.type() == QVariant::Invalid) return def; - const element_type x(b->get(self_name)); + const element_type x(variant.value()); return traits::from_value(traits::from_storage(x), def); } -- cgit v1.2.3