From 6d40b2fcdbc2b66fcb0a62b48151035e3aa293d5 Mon Sep 17 00:00:00 2001 From: Stanislaw Halik Date: Sat, 2 Feb 2019 00:50:04 +0100 Subject: api/plugin: add explicit to module_status error ctor --- api/plugin-api.cpp | 3 ++- api/plugin-api.hpp | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) (limited to 'api') diff --git a/api/plugin-api.cpp b/api/plugin-api.cpp index 3630beae..b2329f4b 100644 --- a/api/plugin-api.cpp +++ b/api/plugin-api.cpp @@ -56,7 +56,8 @@ bool module_status::is_ok() const } module_status_mixin::~module_status_mixin() = default; -module_status::module_status(QString error) : error(std::move(error)) {} +module_status::module_status(const QString& error) : error(error) {} +module_status::module_status() = default; module_status module_status_mixin::status_ok() { return {}; } module_status module_status_mixin::error(const QString& error) diff --git a/api/plugin-api.hpp b/api/plugin-api.hpp index 1bfce7d5..137ee46d 100644 --- a/api/plugin-api.hpp +++ b/api/plugin-api.hpp @@ -97,7 +97,8 @@ struct OTR_API_EXPORT module_status final QString error; bool is_ok() const; - module_status(QString error = {}); + module_status(); + explicit module_status(const QString& error); }; /* -- cgit v1.2.3