From ba038ce052af5ada52a0117c9f13e44cf1c63f1c Mon Sep 17 00:00:00 2001
From: Stanislaw Halik <sthalik@misaki.pl>
Date: Sat, 6 May 2017 13:34:22 +0200
Subject: spline: refactor

Generally nothing of importance, just readability.

- There was a particularly scary typo where:

      const unsigned end = std::min(unsigned(value_count), unsigned(p2_x * mult_));

  clamping to value_count doesn't make sense, given arbitrary p2_x.

- Try harder to avoid assigning s->points. Also the overlap
  threshold constant was arbitrarily too high.

- Sort predicate is meant to use strict ordering,
  not partial total order.
---
 spline/spline.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'spline/spline.hpp')

diff --git a/spline/spline.hpp b/spline/spline.hpp
index acb1861a..7098f125 100644
--- a/spline/spline.hpp
+++ b/spline/spline.hpp
@@ -42,7 +42,7 @@ signals:
 
 class OTR_SPLINE_EXPORT spline final
 {
-    double precision(const QList<QPointF>& points) const;
+    double bucket_size_coefficient(const QList<QPointF>& points) const;
     void update_interp_data();
     float get_value_internal(int x);
     void add_lone_point();
-- 
cgit v1.2.3