| Age | Commit message (Collapse) | Author |
|---|
|
This reverts commit a67e8630caf20e7f48151024e9e68dd9271d75c7.
|
|
This is useful not just to save on complexity in call sites, but also
because I plan on using the Verdigris library to remove needless
`valueChanged()` and `setValue()` overloads from each `value<t>`
instance.
Also fix a bug in `options/tie.hpp` where `QComboBox::setCurrentIndex`
was erroneously called as `Qt::DirectConnection`.
|
|
|
|
|
|
|
|
- replace `static constexpr inline' with `static constexpr'.
`inline' is implied.
- use braced initializer lists where applicable
- still missing `override' usages
|
|
|
|
No functional changes.
- add `override' everywhere where missing
- almost pass clang's `-Wweak-vtables'
- avoid some float/double conversions
- remove unused private members
- make signedness conversions explicit
- put stuff in right namespaces to aid analysis
|
|
Using int as `stored_type' for bool made Qt signals not
work. Evident when ticking the "asymmetric mapping"
checkboxes in the mapping window.
Remove some std::decay_t usage, there's no need for
either decay or remove_cvref.
In `value<t>::get()', `bundle::get_variant' of an
undefined key will fall back to `return def' so remove
the duplicate logic.
|
|
Issue: #726
|
|
Rename traits' functions to be more explicit.
Most of the changes are pretty old and I can't read
them at this time, sorry.
Adjust usages.
Issue: #825
Reported-by: @DanielKinsman
|
|
1. Calling valueChanged didn't invoke machinery in
value<t>, only base_value aka value_.
There's a fast path in value<t>::type() despite the
pessimization.
2. Split global scope stuff into options::globals from
the options::globals stuff
3. Adjust usages
|
|
|
|
Use more C++17 features where this helps any.
|
|
|
|
|
|
Some of the headers are clearly useless. Remove them.
Move what's inside util.hpp into separate headers.
Adjust usages.
Will remove util.hpp.
|
|
|
|
|
|
|
|
Also combine the traits classes and make them more useful.
|
